Skip to content

Fix bug on getIssueIDsByRepoID #16119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 10, 2021
Merged

Fix bug on getIssueIDsByRepoID #16119

merged 4 commits into from
Jun 10, 2021

Conversation

lunny
Copy link
Member

@lunny lunny commented Jun 9, 2021

As title.

@lunny lunny force-pushed the lunny/fix_get_issue_ids branch from 2075d58 to 667ea2d Compare June 9, 2021 15:14
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Jun 9, 2021
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jun 9, 2021
@6543 6543 added this to the 1.15.0 milestone Jun 9, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #16119 (56bed92) into main (5fef041) will increase coverage by 0.06%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #16119      +/-   ##
==========================================
+ Coverage   44.17%   44.24%   +0.06%     
==========================================
  Files         694      694              
  Lines       82323    82323              
==========================================
+ Hits        36367    36420      +53     
+ Misses      40072    40023      -49     
+ Partials     5884     5880       -4
Impacted Files Coverage Δ
models/issue.go 58.87% <100.00%> (ø)
models/unit.go 46.57% <0.00%> (-2.74%) ⬇️
services/pull/pull.go 43.37% <0.00%> (-0.46%) ⬇️
modules/queue/workerpool.go 53.81% <0.00%> (+0.76%) ⬆️
services/gitdiff/gitdiff.go 73.76% <0.00%> (+1.41%) ⬆️
modules/indexer/issues/indexer.go 61.53% <0.00%> (+1.53%) ⬆️
services/pull/patch.go 55.93% <0.00%> (+1.69%) ⬆️
modules/log/event.go 61.79% <0.00%> (+1.88%) ⬆️
services/pull/check.go 28.27% <0.00%> (+2.75%) ⬆️
services/pull/temp_repo.go 29.78% <0.00%> (+3.19%) ⬆️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5fef041...56bed92. Read the comment docs.

@6543 6543 merged commit 179c727 into go-gitea:main Jun 10, 2021
@lunny lunny deleted the lunny/fix_get_issue_ids branch June 10, 2021 01:28
lunny added a commit to lunny/gitea that referenced this pull request Jun 10, 2021
@lunny
Fix bug on getIssueIDsByRepoID (go-gitea#16119)
326cacc 
* Fix bug on getIssueIDsByRepoID

* Add test
@lunny lunny mentioned this pull request Jun 10, 2021
Merged
@6543 6543 added the backport/done All backports for this PR have been created label Jun 10, 2021
zeripath pushed a commit that referenced this pull request Jun 10, 2021
@lunny
Fix bug on getIssueIDsByRepoID (#16119) (#16124)
41a4047 
* Fix bug on getIssueIDsByRepoID

* Add test
AbdulrhmnGhanem pushed a commit to kitspace/gitea that referenced this pull request Aug 10, 2021
@lunny @AbdulrhmnGhanem
Fix bug on getIssueIDsByRepoID (go-gitea#16119)
967b818 
* Fix bug on getIssueIDsByRepoID

* Add test
@go-gitea go-gitea locked and limited conversation to collaborators Oct 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
2 more reviewers

@zeripath zeripath zeripath approved these changes

@adelowo adelowo adelowo approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Milestone
1.15.0
Development

Successfully merging this pull request may close these issues.
6 participants
@lunny @codecov-commenter @zeripath @adelowo @GiteaBot @6543